Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect url prompt #36

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Add connect url prompt #36

merged 4 commits into from
Feb 21, 2023

Conversation

tnederlof
Copy link
Contributor

@tnederlof tnederlof commented Feb 17, 2023

Closes #22

This PR adds the following prompts:

  1. Ask users if they want to enter a default Connect URL
  2. If yes, then asks users to enter a URL
  3. The URL is cleaned and validated

The validation was a bit tricky here but in the end used the health check ping endpoint to ensure the address is correct. The verify code cleans up the URL first (removes a trailing slash, if not http/https adds it) and then verifies a good success code.

Video below

Screen.Recording.2023-02-17.at.3.22.51.PM.mov

@tnederlof tnederlof self-assigned this Feb 17, 2023
@tnederlof tnederlof merged commit 163e28b into main Feb 21, 2023
@dpastoor dpastoor deleted the add-connect-url-prompt branch February 23, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt a user for their Connect URL
2 participants